Handle process creation differently for Windows and Unix#75
Open
pashneal wants to merge 1 commit intobattlecode:masterfrom
Open
Handle process creation differently for Windows and Unix#75pashneal wants to merge 1 commit intobattlecode:masterfrom
pashneal wants to merge 1 commit intobattlecode:masterfrom
Conversation
Linux systems do not support the creationflags parameter - This PR attempts to fix that by using the `start_new_session` parameter on non-windows systems instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unix systems do not support the creationflags parameter - This PR attempts to fix that by using the
start_new_sessionparameter on non-Windows systems instead.I get the following error on my machine